Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appmesh): Update enums for appmesh #8716

Merged
merged 4 commits into from
Jul 8, 2020
Merged

fix(appmesh): Update enums for appmesh #8716

merged 4 commits into from
Jul 8, 2020

Conversation

NickBlow
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@NickBlow NickBlow changed the title Update enums for appmesh Fix: Update enums for appmesh Jun 24, 2020
@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@NickBlow NickBlow changed the title Fix: Update enums for appmesh fix: Update enums for appmesh Jun 24, 2020
@SomayaB SomayaB changed the title fix: Update enums for appmesh fix(app-mesh): Update enums for appmesh Jun 25, 2020
@SomayaB SomayaB changed the title fix(app-mesh): Update enums for appmesh fix(appmesh): Update enums for appmesh Jun 25, 2020
@MrArnoldPalmer
Copy link
Contributor

@NickBlow the build is failing with some awslint errors. You can add the properties to the ignore list in package.json for now.

Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix awslint failures

@MrArnoldPalmer MrArnoldPalmer added @aws-cdk/aws-appmesh Related to AWS App Mesh effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed @aws-cdk/aws-appmesh Related to AWS App Mesh effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. labels Jun 29, 2020
@mergify mergify bot dismissed MrArnoldPalmer’s stale review June 30, 2020 15:30

Pull request has been modified.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jul 1, 2020
@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3234026
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 64e3d88 into aws:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants